Skip to content

Conversation

zeldrisho
Copy link
Contributor

@zeldrisho zeldrisho commented Oct 2, 2025

Closes #14390

scoop bucket add zeldrisho https://github.com/zeldrisho/scoop-bucket
scoop install zeldrisho/proton-pass

Summary by CodeRabbit

  • New Features

    • Added Proton Pass (v1.32.7) to the app catalog for installation.
    • Creates a desktop/start menu shortcut labeled “Proton Pass”.
    • Enables automatic version checking and streamlined updates.
    • Verifies downloads with integrity checks.
  • Chores

    • Added app metadata (description, homepage, license) to improve discoverability.

Copy link

coderabbitai bot commented Oct 2, 2025

Walkthrough

Adds a new Scoop manifest bucket/proton-pass.json for Proton Pass (v1.32.7) declaring metadata, download URL and SHA256, extraction folder, a "Proton Pass" shortcut, checkver pointing to a version.json with regex, and an autoupdate download URL template.

Changes

Cohort / File(s) Summary of edits
Scoop manifest: Proton Pass
bucket/proton-pass.json
Added new manifest defining version 1.32.7, metadata (description, homepage, license GPL-3.0), installer download URL and SHA256, extract_dir, shortcut mapping ProtonPass.exe → "Proton Pass", checkver using version.json with a regex to capture Version, and autoupdate URL template.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor User
    participant Scoop as Scoop CLI
    participant Manifest as proton-pass.json
    participant Server as proton.me
    participant OS as System

    User->>Scoop: scoop install proton-pass
    Scoop->>Manifest: read metadata (url, sha256, extract_dir, shortcut)
    Scoop->>Server: download ProtonPass_Setup_[version].exe
    Server-->>Scoop: installer binary
    Scoop->>OS: verify SHA256, extract to extract_dir
    OS-->>Scoop: files installed
    Scoop->>OS: create shortcut "Proton Pass" -> ProtonPass.exe
    Note over Scoop,OS: Installation complete

    User->>Scoop: scoop checkup / scoop update
    Scoop->>Manifest: fetch checkver (version.json), apply regex
    Server-->>Scoop: {"Version":"x.y.z"}
    alt newer version available
        Scoop->>Manifest: construct autoupdate URL template
    else up-to-date
        Note over Scoop: no update needed
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A nibble of JSON, a hop and a pass,
I placed a manifest into Scoop’s grassy mass.
Shortcuts snug, checks in place with class,
Hashes aligned, downloads come to pass.
Rabbit claps paws — Proton Pass at last! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title "proton-pass: Add version 1.32.7" directly and clearly describes the main change in this pull request. It follows a concise format that immediately conveys the purpose of adding a new manifest file for Proton Pass at version 1.32.7. The title is specific enough that a teammate scanning the repository history would understand the primary change without ambiguity.
Linked Issues Check ✅ Passed The code changes satisfy all coding-related requirements from issue #14390. The PR adds a new manifest file (bucket/proton-pass.json) for Proton Pass, which fulfills the request to add this password manager application to the repository. The manifest includes the correct application name, homepage (https://proton.me/pass), description as a password manager, version-specific download URL, and standard installation configuration. The version 1.32.7 included is newer than the 1.24.1 mentioned in the issue, aligning with the requirement for the latest stable version.
Out of Scope Changes Check ✅ Passed All changes in this pull request are directly in-scope and related to the stated objective of adding Proton Pass to the repository. The single file modified is bucket/proton-pass.json, which is a new manifest file for the application. There are no extraneous modifications, refactoring changes, or unrelated updates included in this changeset. The changes are focused exclusively on fulfilling the requirements specified in issue #14390.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c6ed0d and 413e5d3.

📒 Files selected for processing (1)
  • bucket/proton-pass.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/proton-pass.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

github-actions bot commented Oct 2, 2025

All changes look good.

Wait for review from human collaborators.

proton-pass

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@Hungonthose77 Hungonthose77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: proton-pass

2 participants